Replace the Log4j implementation with Logback #5673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configured precision of 36 never really had any effect as the number refers to the number of name components, not characters, and no logger name exceeded 36 components. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
These versions could theoretically be different, and independent versioninig eases the migration to a different logging implementation only while keeping the API. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This change is not so much about the past security flaws in the Log4j implementation [1], but more about generally switching (back) to a more lightweight logger that also plays more nicely with GraalVM [2]. However, stick to Log4j on the API side as it is more powerful than SLF4J, see [3]. This commit restores the Logback configuration files from bac29f6 and updates them with changes meanwhile done to `log4j2.xml`. [1]: https://blog.ltgt.net/migrating-off-log4j2/ [2]: micronaut-projects/micronaut-core#6041 (comment) [3]: https://kajalrawal.medium.com/log4j2-is-it-worth-to-use-slf4j-with-log4j2-21e83d0d792c Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
See [1]. Once [2] is resolved the official Gradle plugin should be used instead of the current Palantir plugin [3] to benefit from automatic download of reachability-metadata [4]. Note that still more work is required to make the native-image build succeed. [1]: https://github.com/oracle/graalvm-reachability-metadata/blob/master/metadata/ch.qos.logback/logback-classic/1.2.11/reflect-config.json [2]: graalvm/native-build-tools#100 [3]: https://github.com/palantir/gradle-graal [4]: https://graalvm.github.io/native-build-tools/latest/gradle-plugin.html#metadata-support Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #5673 +/- ##
============================================
- Coverage 65.51% 65.50% -0.02%
Complexity 2212 2212
============================================
Files 271 271
Lines 16580 16580
Branches 3432 3432
============================================
- Hits 10862 10860 -2
- Misses 4575 4577 +2
Partials 1143 1143
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mnonnenmacher
approved these changes
Aug 22, 2022
mnonnenmacher
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.