Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make model serialization more deterministic and re-write several test assets #8656

Merged
merged 4 commits into from
May 17, 2024
Merged

Make model serialization more deterministic and re-write several test assets #8656

merged 4 commits into from
May 17, 2024

Conversation

fviernau
Copy link
Member

See individual commits.

@fviernau
test: Align test assets with recent changes in advisor result model
cfabf36 
See [1] and [2].

[1]: #7762
[2]: #8610

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau
fix(model): Serialize project's scope names in alphabetical order
421a63a 
Make the serialization more deterministic.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau requested a review from a team as a code owner May 17, 2024 09:33
@fviernau fviernau enabled auto-merge (rebase) May 17, 2024 09:35
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (833dac3) to head (2a540a3).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main    #8656   +/-   ##
=========================================
  Coverage     67.92%   67.92%           
  Complexity     1005     1005           
=========================================
  Files           244      244           
  Lines          7772     7772           
  Branches        876      876           
=========================================
  Hits           5279     5279           
  Misses         2110     2110           
  Partials        383      383
Flag Coverage Δ
funTest-non-docker 34.79% <ø> (ø)
test 37.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fviernau
fix(analyzer): Serialize sharedPackages ordered by their id
7d666a2 
Make the serialization more deterministic.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau
test: Re-serialize a couple of test assets
2a540a3 
Use the `RewriteTestAssetsCommand` of the `helper-cli` to re-serialize
the test assets, to re-align with how the serialization currently is
set up. The changes do:

1. A re-ordering, see also preceeding commits, but not limited to
   these.
2. Drop quotes from the map keys of `ScannerRun.scanners`.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau merged commit 889f474 into main May 17, 2024
20 checks passed
@fviernau fviernau deleted the model-serialization-fixes branch May 17, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sschuberth sschuberth sschuberth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fviernau @sschuberth