Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static-html): Make the descriptions of issues more compact #8668

Merged
merged 1 commit into from
May 22, 2024

Conversation

fviernau
Copy link
Member

Only show the Issue.message, but stop showing Issue.timestamp and Issue.severity, to make the representation more compact and to align with the WebApp report. Note that the timestamp is rarely relevant and the severity is represented by a dedicated styling anyway.

@fviernau fviernau requested a review from a team as a code owner May 21, 2024 12:02
@fviernau fviernau enabled auto-merge (rebase) May 21, 2024 12:03
@sschuberth
Copy link
Member

I was a bit hesitant about the rationale at first, as we seem to have tickets that go a little bit into the other direction for the web-app report (like #4041, #8211), but these tickets do not refer to the issue time and severity specifically, so I believe this change is ok.

sschuberth
sschuberth previously approved these changes May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.92%. Comparing base (6ae4429) to head (e3d0c45).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8668   +/-   ##
=========================================
  Coverage     67.92%   67.92%           
  Complexity     1005     1005           
=========================================
  Files           244      244           
  Lines          7772     7772           
  Branches        876      876           
=========================================
  Hits           5279     5279           
  Misses         2110     2110           
  Partials        383      383           
Flag Coverage Δ
funTest-non-docker 34.79% <ø> (ø)
test 37.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Only show the `Issue.message`, but stop showing `Issue.timestamp` and
`Issue.severity`, to make the representation more compact and to align
with the WebApp report. Note that the timestamp is rarely relevant and
the severity is represented by a dedicated styling anyway.

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
@fviernau fviernau merged commit 869bf65 into main May 22, 2024
20 checks passed
@fviernau fviernau deleted the static-html-more-compact-issue-messages branch May 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants