feat(backend): get user by id #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DipandaAser
requested changes
Sep 10, 2021
backend/app/auth/routers.go
Outdated
| @@ -39,4 +39,5 @@ func AuthRouter() { | |||
|
|
|||
| router.GET("/auth", authHandler(*oauthConf)) | |||
| router.POST("/auth", githubCallbackHandler(*oauthConf)) | |||
| router.GET("/user/:userID", getUserByIdHandler) | |||
There was a problem hiding this comment.
Suggested change
| router.GET("/user/:userID", getUserByIdHandler) | |
| router.GET("/users/:userID", getUserByIdHandler) |
elhmn
reviewed
Sep 10, 2021
backend/app/auth/handlers.go
Outdated
| @@ -55,6 +84,7 @@ func githubCallbackHandler(oauthConf oauth2.Config) gin.HandlerFunc { | |||
| return gin.HandlerFunc(fn) | |||
| } | |||
|
|
|||
| // authHandler will return the url to the clien with the githubClientID for him to logIN | |||
There was a problem hiding this comment.
Suggested change
| // authHandler will return the url to the clien with the githubClientID for him to logIN | |
| // authHandler will return the url to the client with the githubClientID for him to logIN |
|
LGTM. Thanks @Sanix-Darker |
DipandaAser
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ?
We need to get an user by it's ID
How ?
Steps to verify:
Just by running :
curl http://127.0.0.1:9999/api/user/:userIDafter creating a user, the userID is the ID of that user !Screenshots (optional):