Remove ui.nsi #118
Merged
Remove ui.nsi #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't seem to figure out what purpose the ui.nsi file serves if any. In my tests on Windows 2008R2 not making it and even having it present seem to make no difference in the agent functionality. The win32ui still gets installed and everything about it still seems to work. Getting rid of it seems like a good idea to me at this point.
|
I think you are correct. I looked at this awhile back and couldn't figure it out either. |
|
Sounds okay to get rid of. The more we can get rid of and clean up the better we can make things. So many more issues to take care of in ossec-installer.nsi 😦 |
|
thanks for all this great work @awiddersheim with win32 🐹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't seem to figure out what purpose the ui.nsi file serves if any.
In my tests on Windows 2008R2 not making it and even having it present
seem to make no difference in the agent functionality. The win32ui
still gets installed and everything about it still seems to work.
Getting rid of it seems like a good idea to me at this point.
If anyone can tell me if this does get used for anything and what that anything is it would be much appreciated. Further testing always welcome.