analysisd: fix heap overflow in rootkit decoder. #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RK_File` function of the rootcheck decoder needs to ensure it doesn't index outside of `MAX_AGENTS` when trying to find/open a rootcheck file for a given agent. Prev. to this change the value of `i` could exceed `MAX_AGENTS` resulting in a heap buffer overflow accessing `rk_agent_ips[i]` or `rk_agent_fps[i]`. The fix is adapted from similar logic in the syscheck decoder, added as a response to a matching vulnerability in that decoder patched in 2012.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RK_Filefunction of the rootcheck decoder needs to ensure it doesn't index outside ofMAX_AGENTSwhen trying to find/open a rootcheck file for a given agent.Prev. to this change the value of
icould exceedMAX_AGENTSresulting in a heap buffer overflow accessingrk_agent_ips[i]orrk_agent_fps[i].The fix is adapted from similar logic in the syscheck decoder, added as a response to a matching vulnerability in that decoder patched in 2012.
Resolves #1820