Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter data source #28

Merged
merged 10 commits into from May 4, 2018
Merged

Twitter data source #28

merged 10 commits into from May 4, 2018

Conversation

dsalahutdinov
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #28 into master will decrease coverage by 0.22%.
The diff coverage is 94.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   96.71%   96.48%   -0.23%     
==========================================
  Files          38       60      +22     
  Lines        1734     2278     +544     
==========================================
+ Hits         1677     2198     +521     
- Misses         57       80      +23
Impacted Files Coverage Δ
lib/ossert/project.rb 100% <ø> (ø) ⬆️
lib/ossert/twitter/metrics_averager.rb 100% <100%> (ø)
lib/ossert/twitter.rb 100% <100%> (ø)
spec/ossert/twitter/metrics_averager_spec.rb 100% <100%> (ø)
lib/ossert.rb 100% <100%> (ø) ⬆️
lib/ossert/saveable.rb 97.1% <100%> (+0.04%) ⬆️
spec/ossert/workers/fetch_twitter_spec.rb 100% <100%> (ø)
...ec/ossert/twitter/search_results_validator_spec.rb 100% <100%> (ø)
lib/ossert/fetch.rb 81.81% <100%> (+0.27%) ⬆️
lib/ossert/twitter/metrics_updater.rb 100% <100%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdb56a...85090de. Read the comment docs.

@dsalahutdinov
Copy link
Contributor Author

🍏

@@ -0,0 +1,19 @@
REDIS_URL=redis://localhost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you need add this file to gitignore, because your config can differ from others.
But add dotenv its great, I thought about it too.

@dsalahutdinov
Copy link
Contributor Author

Just add you .env.test.local

Copy link
Member

@sclinede sclinede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay for me.

@sclinede sclinede merged commit e2d77e8 into ossert:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants