Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptConfig should have a setting "optOutArchivedRepos" #108

Closed
Hixie opened this issue Jan 27, 2022 · 2 comments · Fixed by #143
Closed

OptConfig should have a setting "optOutArchivedRepos" #108

Hixie opened this issue Jan 27, 2022 · 2 comments · Fixed by #143
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Hixie
Copy link

Hixie commented Jan 27, 2022

When we enable allstar on the flutter org, it filed about 37 issues complaining that branch protection wasn't enabled on various repos.

All of these were archived, read-only repos. These don't need branch protection, since they have the ultimate protection of being entirely unmodifiable.

@jeffmendoza
Copy link
Member

I haven't looked into the repo metadata GitHub for read-only. I'll take a look. We should probably have something like optOutReadOnly similar to optOutPrivateRepos

@jeffmendoza
Copy link
Member

Updated title.
Similar to the #54 optOutPrivateRepos setting. current logic is here:

func isEnabled(ctx context.Context, o OrgOptConfig, r RepoOptConfig, rep repositories, owner, repo string) (bool, error) {

@jeffmendoza jeffmendoza changed the title Archived repos should not need branch protection OptConfig should have a setting "optOutArchivedRepos" Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants