Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS #736

Closed
Closed

Conversation

x37v
Copy link
Contributor

@x37v x37v commented Jun 7, 2021

This allows for browser based requests to a libossia http server... so that we can create browser based UIs that do OSCQuery discovery.

https://developer.mozilla.org/en-US/docs/Glossary/CORS

@x37v
Copy link
Contributor Author

x37v commented Jun 7, 2021

I guess I should rebase on origin? maybe just cherry-pick that commit if you want it?

@jcelerier
Copy link
Member

Looks good, thanks ! If I understand correctly this means that a web page on e.g. example.com will accept to do a request to an oscquery server located at bar.com:1234, right ?

@jcelerier
Copy link
Member

indeed since it's one line I'll just cherry-pick it on master

@jcelerier
Copy link
Member

I imagine there are some security implications around this, I'll add it to the (upcoming) github kanban board regarding network security in libossia so that we can review more in depth if for instance there are settings that should be provided to the user, etc... in the meantime thanks for the patch !

@jcelerier jcelerier closed this Jun 7, 2021
@x37v
Copy link
Contributor Author

x37v commented Jun 7, 2021

Looks good, thanks ! If I understand correctly this means that a web page on e.g. example.com will accept to do a request to an oscquery server located at bar.com:1234, right ?

yeah, its a browser that controls the acceptance or not but, exactly... a webpage served from example.com can do an HTTP request to an oscquery http server bar.com:5678 (i changed to default ports)

the * just allows any webpage to do the request.. example.com foo.com localhost etc.

@x37v
Copy link
Contributor Author

x37v commented Jun 7, 2021

I imagine there are some security implications around this, I'll add it to the (upcoming) github kanban board regarding network security in libossia so that we can review more in depth if for instance there are settings that should be provided to the user, etc... in the meantime thanks for the patch !

yeah, maybe this would want to be a configurable thing eventually.. but in the short term, i'm excited to make some web based UI for my libossia based project!

@x37v x37v deleted the xnor/async_protocols-cors branch June 7, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants