Cmake fixes #82
Merged
Cmake fixes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 29, 2016 09:23
This will try to find existing ossim installation and therby linking all ossim apps with wrong library. The trick is to simply put ossim library as a dependency to all ossim apps. I had used OSSIM_LIBNAME to allow changing name of libossim.so (default is ossim) Two macros LINK_INTERNAL and LINK_EXTERNAL are removed. As ossim required cmake version 2.8 or higher both macros are simply calling target_link_libraries from cmake.
|
is this need any further fixes before merge? |
|
Hello Rashad:
Thank you for the submissions!
There were significant CMAKE modifications that are tough to see if they will work by tracing the diffs. I have committed but we have had several errors. At this time I am going to patch them and fix the errors for the merge. I am trying to see why a new variable was used OSISM_LIBNAME instead of staying with the OSSIM_LIBRARY variable. If one is building out of project and OSSIM is installed with an RPM and using the ossim CMake files I am not sure at this time how that will behave .
I may have to move the ossimConfig.h back to where it was. External projects are not finding the include files. Will try to fix ii and see.
Take care
Garrett
… On Jan 20, 2017, at 6:54 AM, Rashad ***@***.***> wrote:
is this need any further fixes before merge?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL9vyAeUjgeP7U9CWYiQdod7S0XpqNkks5rUKCFgaJpZM4LXnec>.
|
|
OSISM_LIBNAME is name of library which was ossim. I don't know if that is needed. But before ther was a LIBNAME which is set to ossim. This can control output library name for others. IIUC, OSSIM_LIBRARY is full path to libossim file. In the app directory, it makes sense to make all apps depend on cmake target 'ossim' or whatever with name OSSIM_LIBNAME. This also make sure any change in ossim core will rebuild ossim apps. otherwise one has to manually rebuild all apps after having a update in libossim.so or can get "random" crashes. If you have any confusion, let me know in which part of cmake changes. I can then comment on it in detail. |
|
I have a fix for building ossim apps using an existing installation of ossim. If you are okay, I can send another PR.? |
|
Hello Rashad:
make installs are no long installing all the other sub modules. Need to fix that real quick
Take care
Garrett
… On Jan 20, 2017, at 8:17 AM, Rashad ***@***.***> wrote:
I have a fix for building ossim apps using an existing installation of ossim. If you are okay, I can send another PR.?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL9v566CDzgcC-cJ-R7ZizIxr2d_yjiks5rULPsgaJpZM4LXnec>.
|
|
Hello Rashad:
I had a to reset the head to the last know good builds. At this time I can’t do the cmake list fixes for all our modules do not build with the updates and fails also during the RPM build. We are in the middle of some tasks that I can’t give it any more time right now.
I had to reset the commit back to Jan 18th before the merge today.
Take care
Garrett
… On Jan 20, 2017, at 8:17 AM, Rashad ***@***.***> wrote:
I have a fix for building ossim apps using an existing installation of ossim. If you are okay, I can send another PR.?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#82 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACL9v566CDzgcC-cJ-R7ZizIxr2d_yjiks5rULPsgaJpZM4LXnec>.
|
|
okay. can you ping me when you had done with these tasks. we can then discuss about some issues in cmake. Good luck. |
grizonnetm
referenced
this pull request
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is built on top of #81 and include some cmake fixes.