A message must have a non-empty command #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, empty string and ": " were treated as valid messages.
|
Merged this manually, sorry it took so long. Starting with 3.0, irc-message provides a Transform stream out of the box (with options to parse IRCv3 message tags, prefixes, etc) too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how strict this parser is intended to be, but I have a light wrapper around it to make a transform stream and was writing tests when I encountered a few unexpected failures.
According to the pseudo BNF in RFC1459, the command part of a message is required and must be at least 1 character (1+ letters or exactly 3 digits, but that's a separate issue if it's wanted). This change makes the parser treat empty string and things like ": " as malformed in the same way that it already treats ":".