Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a popping sound when converting RTMP to WebRTC for playback. #2106

Closed
zsinba opened this issue Dec 24, 2020 · 7 comments
Closed

There is a popping sound when converting RTMP to WebRTC for playback. #2106

zsinba opened this issue Dec 24, 2020 · 7 comments
Assignees
@winlinvip
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Milestone
4.0

Comments

@zsinba
Copy link

zsinba commented Dec 24, 2020 •
edited by winlinvip
Loading

Description
Push the stream using RTMP and play it using WEBRTC with zilazila sound.
It seems that this issue has been resolved in this pull request, but it still exists in version 4.0: ea318b5

TRANS_BY_GPT3
@zsinba
Copy link
Author

zsinba commented Dec 24, 2020 •
edited by winlinvip
Loading

Confirmed, please fill in the missing form so there won't be any missing explosion forms. Hoping the boss will patch it up.

TRANS_BY_GPT3

@PieerePi
Copy link
Contributor

PieerePi commented Dec 24, 2020 •
edited by winlinvip
Loading

@winlinvip Please merge PR #2011. Make sure to maintain the markdown structure.

TRANS_BY_GPT3

@ghostsf
Copy link
Contributor

ghostsf commented Jan 13, 2021 •
edited by winlinvip
Loading

Any more questions? Awkward, there are a bunch of bugs in the 4.0 release.

TRANS_BY_GPT3

@PieerePi
Copy link
Contributor

PieerePi commented Jan 13, 2021 •
edited by winlinvip
Loading

It hasn't been merged yet, winlinvip said there is a better method.
But this issue has indeed been going on for quite a long time, it is a basic functionality...

TRANS_BY_GPT3

@ghostsf
Copy link
Contributor

ghostsf commented Jan 13, 2021 •
edited by winlinvip
Loading

It has not been merged yet, winlinvip said there is a better method.
But this issue has indeed been going on for quite a long time, it is a fundamental feature...

Yes. Looking at your code, there shouldn't be any issues. The tests are also okay.

TRANS_BY_GPT3

@winlinvip winlinvip added the WebRTC WebRTC, RTC2RTMP or RTMP2RTC. label Jan 18, 2021
@winlinvip
Copy link
Member

winlinvip commented Mar 3, 2021 •
edited
Loading

#2011 is closed because the original branch of PR is closed, not merged.

TRANS_BY_GPT3

@winlinvip winlinvip mentioned this issue Mar 3, 2021
Closed
winlinvip added a commit that referenced this issue Mar 3, 2021
@winlinvip
Fix #2106, #2011, RTMP/AAC transcode to Opus bug. 4.0.81
1826e0e
winlinvip pushed a commit that referenced this issue Mar 3, 2021
@PieerePi @winlinvip
Fix #2106, #2011, RTMP/AAC transcode to Opus bug. 4.0.81
4cf1697
@winlinvip
Copy link
Member

Fixed in 4.0.81

winlinvip pushed a commit that referenced this issue Mar 4, 2021
@PieerePi @winlinvip
Fix #2106, #2011, RTMP/AAC transcode to Opus bug. 4.0.81
4ba4850
@winlinvip winlinvip mentioned this issue Aug 23, 2021
Closed
@winlinvip winlinvip self-assigned this Aug 28, 2021
@winlinvip winlinvip added the Bug It might be a bug. label Aug 28, 2021
@winlinvip winlinvip added this to the 4.0 milestone Sep 4, 2021
@winlinvip winlinvip changed the title RTMP转webrtc播放的时候有爆音 There is a popping sound when converting RTMP to WebRTC for playback. Jul 28, 2023
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winlinvip winlinvip

Labels
Bug It might be a bug. TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
4 participants
@zsinba @winlinvip @ghostsf @PieerePi