Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support transfer flv query params by callback #1339

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

959YLX
Copy link
Contributor

@959YLX 959YLX commented Mar 24, 2019

eg:
when request is "http://localhost/app/stream.flv?token=xxx&salt=yyy", the http callback from srs will take the param("?token=xxx&salt=yyy") in param field

@winlinvip winlinvip changed the base branch from master to 2.0release April 5, 2019 07:42
@winlinvip
Copy link
Member

👍

@winlinvip winlinvip merged commit ab83394 into ossrs:2.0release Apr 5, 2019
winlinvip added a commit that referenced this pull request Apr 5, 2019
@winlinvip
Copy link
Member

winlinvip commented Apr 5, 2019

I test it and did some bug fix at 91c462b and b9750ba

SRS 2.0 HTTP-FLV:

[2019-04-05 10:14:15][trace] post to sessions, req={"action":"on_play","client_id":113,"ip":"","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456","pageUrl":""}
[2019-04-05 10:14:20][trace] post to sessions, req={"action":"on_stop","client_id":113,"ip":"","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456"}

SRS 2.0 RTMP:

[2019-04-05 10:14:58][trace] post to sessions, req={"action":"on_play","client_id":116,"ip":"172.17.0.1","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456","pageUrl":""}
[2019-04-05 10:15:07][trace] post to sessions, req={"action":"on_stop","client_id":116,"ip":"172.17.0.1","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456"}

SRS 3.0 HTTP:

[2019-04-05 10:46:34][trace] post to sessions, req={"action":"on_play","client_id":109,"ip":"","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456","pageUrl":""}
[2019-04-05 10:46:39][trace] post to sessions, req={"action":"on_stop","client_id":109,"ip":"","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456"}

SRS 3.0 RTMP:

[2019-04-05 10:46:59][trace] post to sessions, req={"action":"on_play","client_id":110,"ip":"::ffff:172.17.0.2","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456","pageUrl":""}
[2019-04-05 10:47:44][trace] post to sessions, req={"action":"on_stop","client_id":110,"ip":"::ffff:172.17.0.2","vhost":"__defaultVhost__","app":"live","stream":"livestream","param":"?token=123&salt=456"}

TRANS_BY_GPT3

winlinvip added a commit that referenced this pull request Apr 5, 2019
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants