Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC: Fix nack encode seqnum #2766

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

xiaofeilong
Copy link
Contributor

No description provided.

@xiaozhihong
Copy link
Collaborator

xiaozhihong commented Dec 2, 2021

Thank you for submitting. Can you please provide a uTest? This way, we will never encounter any issues with future changes and we can also verify that the modified code is working correctly.

TRANS_BY_GPT3

@winlinvip winlinvip changed the title fix nack encode seqnum RTC: Fix nack encode seqnum Dec 4, 2021
@winlinvip winlinvip added the WebRTC WebRTC, RTC2RTMP or RTMP2RTC. label Dec 4, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2021

Codecov Report

Merging #2766 (e9ef536) into 4.0release (5ccd63d) will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           4.0release    #2766      +/-   ##
==============================================
+ Coverage       60.15%   60.32%   +0.16%     
==============================================
  Files             121      121              
  Lines           50949    50970      +21     
==============================================
+ Hits            30648    30747      +99     
+ Misses          20301    20223      -78     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/kernel/srs_kernel_rtc_rtcp.cpp | 15.51% <100.00%> (+10.27%) | ⬆️ |
| trunk/src/utest/srs_utest_rtc.cpp | 99.40% <100.00%> (+0.01%) | ⬆️ |
| trunk/src/kernel/srs_kernel_rtc_rtp.hpp | 54.54% <0.00%> (+9.09%) | ⬆️ |


Continue to review full report at Codecov.

Legend - Click here to learn more
Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 5ccd63d...e9ef536. Read the comment docs.

TRANS_BY_GPT3


SrsRtcpNack rtcpNack_encode(ssrc);
for(uint16_t i = 16; i < 50; ++i) {
rtcpNack_encode.add_lost_sn(i);
Copy link
Collaborator

@xiaozhihong xiaozhihong Dec 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rtcpNack_encode, rtcpNack_decode, It is better to name them consistently with the style of srs, so change them to rtcp_nack_encode, rtcp_nack_decode would be better.

TRANS_BY_GPT3

@winlinvip winlinvip merged commit 4decc1f into ossrs:4.0release Dec 6, 2021
@winlinvip
Copy link
Member

@xiaofeilong @xiaozhihong 👍

winlinvip added a commit that referenced this pull request Dec 6, 2021
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT. WebRTC WebRTC, RTC2RTMP or RTMP2RTC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants