Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security: Enable CIDR for allow/deny play/publish #2914

Merged
merged 10 commits into from
Mar 11, 2022

Conversation

duiniuluantanqin
Copy link
Member

@duiniuluantanqin duiniuluantanqin commented Feb 12, 2022

Summary

Based on #1753, without infringing copyright.


TRANS_BY_GPT3

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2022

Codecov Report

Merging #2914 (30e5d22) into develop (1b08fb6) will increase coverage by 2.00%.
The diff coverage is 92.13%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2914      +/-   ##
===========================================
+ Coverage    58.21%   60.21%   +2.00%     
===========================================
  Files          114      121       +7     
  Lines        48244    51704    +3460     
===========================================
+ Hits         28084    31133    +3049     
- Misses       20160    20571     +411     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/protocol/srs_protocol_utility.hpp | 100.00% <ø> (ø) | |'

Translated to English while maintaining the markdown structure:

| trunk/src/protocol/srs_protocol_utility.hpp | 100.00% <ø> (ø) | |
| trunk/src/app/srs_app_security.cpp | 86.11% <80.00%> (-3.89%) | ⬇️ |
| trunk/src/protocol/srs_protocol_utility.cpp | 90.72% <89.47%> (-5.89%) | ⬇️ |
| trunk/src/utest/srs_utest_rtmp.cpp | 99.84% <100.00%> (+<0.01%) | ⬆️ |
| trunk/src/kernel/srs_kernel_buffer.cpp | 66.33% <0.00%> (-30.71%) | ⬇️ |
| trunk/src/app/srs_app_st.cpp | 81.15% <0.00%> (-18.85%) | ⬇️ |
| trunk/src/app/srs_app_config.cpp | 65.54% <0.00%> (-3.06%) | ⬇️ |
| trunk/src/app/srs_app_listener.cpp | 9.74% <0.00%> (-3.03%) | ⬇️ |
| ... and 143 more | |


Continue to review full report at Codecov.

Legend - Click here to learn more
| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Translated to English while maintaining the markdown structure:

| Δ = absolute <relative> (impact), ø = not affected, ? = missing data |

Powered by Codecov. Last update 1b08fb6...30e5d22. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

NICE 👍

@macabu
Copy link
Contributor

macabu commented Feb 14, 2022

Hi @duiniuluantanqin , thanks for the rebase and fixes.
Would you consider cherry picking this commit from the branch? https://github.com/mycujoo/srs/commit/6a29f5984e2b2120d5a63ac89514a6719f95aa8d
It implements the precedence that is closely with how it works with nginx, so this PR is more useful.

@winlinvip
Copy link
Member

winlinvip commented Feb 15, 2022

@macabu I think we could file another PR for the precedence, after this PR is merged. Now there is still some build failed, for some compile issue on CentOS 6.

@winlinvip winlinvip force-pushed the develop branch 4 times, most recently from 927df62 to 75cf9b3 Compare March 3, 2022 01:40
@winlinvip winlinvip added the Feature It's a new feature. label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature It's a new feature. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants