Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebRTC: Support WHEP for play. v5.0.182 v6.0.80 #3404

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

winlinvip
Copy link
Member

@winlinvip winlinvip commented Feb 6, 2023

RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a document about WHIP, because WHIP is not a RFC right now, but there are clues in srs-unity. SRS WHIP url for publisher: http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream

This PR is for WHEP, the url for player is http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream

PS: There is a great PR for OBS to have WHIP support, see obsproject/obs-studio#7926 and #3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See #3170


Co-authored-by: Haibo Chen 495810242@qq.com
Co-authored-by: john hondaxiao@tencent.com
Co-authored-by: ChenGH chengh_math@126.com

@johan149
Copy link

Wow great work!

@winlinvip
Copy link
Member Author

Seems WHEP is not updated, so we should hold on this PR, and shouldn't merge it util WHEP has some updates.

@winlinvip winlinvip force-pushed the develop branch 3 times, most recently from c056094 to 2ac9eb8 Compare March 23, 2023 06:02
@duiniuluantanqin
Copy link
Member

WHEP updated on 2023-03-29, maybe it can be merged.

Seems WHEP is not updated, so we should hold on this PR, and shouldn't merge it util WHEP has some updates.

@zapf2000
Copy link

zapf2000 commented Jul 10, 2023

When ingesting a WHIP stream in Stereo it is downmixed to Mono by WHEP Player.

on WHIP side:
a=rtcp-mux
a=rtpmap:111 opus/48000/2
a=rtcp-fb:111 transport-cc
a=fmtp:111 cbr=1;maxaveragebitrate=131072;minptime=10;sprop-stereo=1;stereo=1;useinbandfec=1

on WHEP side:
a=rtcp-mux
a=rtpmap:111 opus/48000/2
a=rtcp-fb:111 transport-cc
a=fmtp:111 minptime=10;useinbandfec=1

No chance to set the custom parameters stereo=1 or sprop-stereo=1 on client side.

@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
@winlinvip winlinvip changed the title WebRTC: Support WHEP for play. WebRTC: Support WHEP for play. v5.0.182 v6.0.80 Sep 21, 2023
@winlinvip winlinvip added the RefinedByAI Refined by AI/GPT. label Sep 21, 2023
@winlinvip winlinvip merged commit f9bba0a into ossrs:develop Sep 21, 2023
17 checks passed
winlinvip added a commit that referenced this pull request Sep 21, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a
document about WHIP, because WHIP is not a RFC right now, but there are
clues in
[srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS
WHIP url for publisher:
`http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream`

This PR is for WHEP, the url for player is
`http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream`

PS: There is a great PR for OBS to have WHIP support, see
obsproject/obs-studio#7926 and #3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See #3170

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: ChenGH <chengh_math@126.com>
duiniuluantanqin added a commit to duiniuluantanqin/srs that referenced this pull request Oct 11, 2023
RFC for WHIP: https://datatracker.ietf.org/doc/draft-ietf-wish-whip/

RFC for WHEP: https://datatracker.ietf.org/doc/draft-murillo-whep/

Please note that SRS 5.0 already had WHIP support. I didn't write a
document about WHIP, because WHIP is not a RFC right now, but there are
clues in
[srs-unity](https://github.com/ossrs/srs-unity#usage-publisher). SRS
WHIP url for publisher:
`http://localhost:1985/rtc/v1/whip/?app=live&stream=livestream`

This PR is for WHEP, the url for player is
`http://localhost:1985/rtc/v1/whep/?app=live&stream=livestream`

PS: There is a great PR for OBS to have WHIP support, see
obsproject/obs-studio#7926 and ossrs#3581

PS: WHIP for FFmpeg ossrs/ffmpeg-webrtc#1

See ossrs#3170

---------

Co-authored-by: Haibo Chen <495810242@qq.com>
Co-authored-by: john <hondaxiao@tencent.com>
Co-authored-by: ChenGH <chengh_math@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English. RefinedByAI Refined by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants