WebRTC: Support configure CANDIDATE by env #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If configure SRS by envirionment variables, for example: ``` SRS_HTTP_API_ENABLED=on SRS_HTTP_SERVER_ENABLED=on \ SRS_RTC_SERVER_ENABLED=on SRS_VHOST_RTC_ENABLED=on \ SRS_RTC_SERVER_CANDIDATE=\$CANDIDATE CANDIDATE=1.2.3.4 \ ./objs/srs -e ``` We should parse the content of SRS_RTC_SERVER_CANDIDATE as env variable name and parse it again.
chundonglinlin
approved these changes
Mar 16, 2023
winlinvip
force-pushed
the
develop
branch
3 times, most recently
from
c056094
to
2ac9eb8
Compare
winlinvip
requested review from
mapengfei53
and removed request for
chen-guanghua
mapengfei53
approved these changes
Mar 27, 2023
winlinvip
added a commit
that referenced
this pull request
Mar 27, 2023
In dockerfile, we can set the default RTC candidate to env: ``` ENV SRS_RTC_SERVER_CANDIDATE=\$CANDIDATE CMD ["./objs/srs", "-e"] ``` When starts a docker container, user can setup the candidate by env: ``` docker run --rm -it --env CANDIDATE=1.2.3.4 ossrs/srs:5 ``` We should parse the content of SRS_RTC_SERVER_CANDIDATE as env variable name and parse it again. PICK b34255c --------- Co-authored-by: chundonglinlin <chundonglinlin@163.com> Co-authored-by: pengfei.ma <pengfei.ma@ctechm.com>
duiniuluantanqin
pushed a commit
to duiniuluantanqin/srs
that referenced
this pull request
Mar 31, 2023
In dockerfile, we can set the default RTC candidate to env: ``` ENV SRS_RTC_SERVER_CANDIDATE=\$CANDIDATE CMD ["./objs/srs", "-e"] ``` When starts a docker container, user can setup the candidate by env: ``` docker run --rm -it --env CANDIDATE=1.2.3.4 ossrs/srs:5 ``` We should parse the content of SRS_RTC_SERVER_CANDIDATE as env variable name and parse it again. --------- Co-authored-by: chundonglinlin <chundonglinlin@163.com> Co-authored-by: pengfei.ma <pengfei.ma@ctechm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dockerfile, we can set the default RTC candidate to env:
When starts a docker container, user can setup the candidate by env:
We should parse the content of SRS_RTC_SERVER_CANDIDATE as env variable name and parse it again.