Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SrsContextId assignment can be improved without create a duplicated one. v5.0.175 v6.0.70 #3503

Merged

Conversation

suzp1984
Copy link
Contributor

@suzp1984 suzp1984 commented Apr 7, 2023

SrsContextId object creation can be improved on srs_protocol_log.cpp, No need to create one, then assign it back. It seems a common mistake for Cpp programmers.


Co-authored-by: john hondaxiao@tencent.com

@suzp1984 suzp1984 force-pushed the bugfix/SrsContextId_assignment_improvement branch from 87f57bc to 4987cd6 Compare April 7, 2023 13:47
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
@winlinvip winlinvip changed the title SrsContextId assignment can be improved without create a duplicated one. SrsContextId assignment can be improved without create a duplicated one. v5.0.175 v6.0.70 Aug 28, 2023
@winlinvip winlinvip added the RefinedByAI Refined by AI/GPT. label Aug 28, 2023
@winlinvip winlinvip force-pushed the bugfix/SrsContextId_assignment_improvement branch from 6c88cf8 to 132ae1d Compare August 28, 2023 07:07
@winlinvip winlinvip merged commit bb93311 into ossrs:develop Aug 28, 2023
17 checks passed
winlinvip pushed a commit that referenced this pull request Aug 28, 2023
…ne. v5.0.175 (#3503)

SrsContextId object creation can be improved on `srs_protocol_log.cpp`,
No need to create one, then assign it back. It seems a common mistake
for Cpp programmers.

---------

Co-authored-by: john <hondaxiao@tencent.com>
duiniuluantanqin pushed a commit to duiniuluantanqin/srs that referenced this pull request Sep 14, 2023
…ne. v5.0.175 (ossrs#3503)

SrsContextId object creation can be improved on `srs_protocol_log.cpp`,
No need to create one, then assign it back. It seems a common mistake
for Cpp programmers.

---------

Co-authored-by: john <hondaxiao@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English. RefinedByAI Refined by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants