Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H264: Fix H.264 ISOM reserved bit value. v5.0.161, v6.0.55 #3551

Merged

Conversation

KazuoHagihara
Copy link
Contributor

@KazuoHagihara KazuoHagihara commented May 25, 2023

The MPEG-DASH receiver that we're using couldn't receive the stream that SRS ouputs.
The reason was that the value of the reserve bit of AVC sequence header was set to 0.

I fixed the reserved bit value to 1.

image

@chundonglinlin
Copy link
Member

This is a great fix, and we can use both the documentation standards(ISO_IEC_14496-15-AVC-format-2012, page 16.) and FFmpeg's processing method as reference(ff_isom_write_avcc).

@winlinvip winlinvip changed the title BugFix: Fix reserved bit value. BugFix: Fix H.264 ISOM reserved bit value. Jun 21, 2023
@winlinvip winlinvip changed the title BugFix: Fix H.264 ISOM reserved bit value. H264: Fix H.264 ISOM reserved bit value. Jun 21, 2023
@winlinvip winlinvip changed the title H264: Fix H.264 ISOM reserved bit value. H264: Fix H.264 ISOM reserved bit value. v5.0.161, v6.0.55 Jun 21, 2023
@winlinvip winlinvip merged commit 43dfb1b into ossrs:develop Jun 21, 2023
17 checks passed
winlinvip pushed a commit that referenced this pull request Jun 21, 2023
---------

Co-authored-by: chundonglinlin <chundonglinlin@163.com>
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants