DASH: Fix time unit error for disposing. v6.0.138 #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
reviewed
Jul 10, 2024
suzp1984
force-pushed
the
debug/dash_dispose_error
branch
from
6209228
to
24a50e6
Compare
Cause: dash auto dispose is configured by seconds, but the code compare by usecond, 1 second = 1,000,000 useconds
suzp1984
force-pushed
the
debug/dash_dispose_error
branch
from
24a50e6
to
1774f4f
Compare
winlinvip
changed the title
winlinvip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause
dash auto dispose is configured by seconds, but the code compare by usecond, 1 second = 1,000,000 useconds.
releated to #4097
Bug introduced after #4097 supported Dash auto dispose after a timeout without media data.
How to reproduce
./objs/srs -c conf/dash.conf