Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A rename gone wrong #81

Closed
dragos-rosca opened this issue Apr 28, 2022 · 0 comments · Fixed by #82
Closed

A rename gone wrong #81

dragos-rosca opened this issue Apr 28, 2022 · 0 comments · Fixed by #82
Assignees
@alexandra-c
Labels
good first issue Good for newcomers

Comments

@dragos-rosca
Copy link
Contributor

generator-graphql-rocket/generators/app/templates/infrastructure/src/middleware/tenantIdentification/index.js

Lines 6 to 7 in 5f1ae0c

const externalTenantId = getTenantIdFromJwt(ctx)
const tenant = await tenantFactory.getTenantFromId(tenantId)

it seems that at the last commit tenantId was renamed into externalTenantId but only at the declaration. Making it's first use a bug of variable not defined
@alexandra-c alexandra-c added the good first issue Good for newcomers label Jun 14, 2022
alexandra-c added a commit that referenced this issue Jun 14, 2022
@alexandra-c
Fixing a rename gone wrong #81
f448292 
This fixes  #81
@alexandra-c alexandra-c mentioned this issue Jun 14, 2022
Merged
alexandra-c added a commit that referenced this issue Jun 14, 2022
@alexandra-c
Merge pull request #82 from osstotalsoft/externalTenantId-rename
c2697b0 
Fixing a rename gone wrong #81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexandra-c alexandra-c

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing a rename gone wrong #81 osstotalsoft/generator-graphql-rocket
2 participants
@dragos-rosca @alexandra-c