pranay/gh43/minorfixedondev #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/2_04_API_AIRDROP_DROP.md
Outdated
| @@ -33,7 +33,7 @@ where the signature is derived from the API secret key and the string to sign is | |||
|
|
|||
| so that the full request uri and form reads | |||
|
|
|||
| > POST - `https://playgroundapi.ost.com/users/airdrop/drop?amount=AMOUNT&api_key=API_KEY&list_type=LIST_TYPE&request_timestamp=EPOCH_TIME_SEC&signature=SIGNATURE` | |||
There was a problem hiding this comment.
weren't the quote marks added everywhere?
There was a problem hiding this comment.
readded them in the latest commits.
docs/2_04_API_AIRDROP_DROP.md
Outdated
| @@ -20,7 +20,7 @@ This API allows end-users to receive or be awarded a selected amount of branded | |||
|
|
|||
| ### Airdrop Sub-Attributes | |||
|
|
|||
| #### **_list_type_** | |||
| ### _list_type_ | |||
| @@ -24,7 +24,7 @@ where the signature is derived from the API secret key and the string to sign is | |||
|
|
|||
| so that the full request uri and form reads | |||
|
|
|||
| > POST - `https://playgroundapi.ost.com/users/airdrop/status?airdrop_uuid=AIRDROP_UUID&api_key=API_KEY&request_timestamp=EPOCH_TIME_SEC&signature=SIGNATURE` | |||
| > GET - https://playgroundapi.ost.com/users/airdrop/status?airdrop_uuid=AIRDROP_UUID&api_key=API_KEY&request_timestamp=EPOCH_TIME_SEC&signature=SIGNATURE | |||
docs/2_05_API_AIRDROP_STATUS.md
Outdated
| @@ -36,15 +36,15 @@ so that the full request uri and form reads | |||
|
|
|||
| On calling `/users/airdrop/status` the `data.airdrop_uuid` is a string containing the airdrop reference id. `data.current_status` is a string containing the present status of the airdrop request. `data.steps_complete` is an array explaining the steps which have been completed for the airdrop at the specific point in time of the API request. | |||
|
|
|||
| #### _current status_ | |||
| ### _current status_ | |||
There was a problem hiding this comment.
list_type; same font as...
docs/2_05_API_AIRDROP_STATUS.md
Outdated
| | Attribute | Type | Description | | ||
| |-----------|---------|------------------------------------------| | ||
| | _pending_ | String | The string to represent that airdrop is still in process. | ||
| | _failed_ | String | The string to represent that the airdrop has failed. | ||
| | _complete_ | String | The string to represent that the airdrop process is complete.| | ||
|
|
||
|
|
||
| #### _steps complete_ | ||
| ### _steps complete_ |
added 2 commits
March 19, 2018 18:31
benjaminbollen
approved these changes
Mar 22, 2018
| @@ -28,7 +28,7 @@ where the signature is derived from the API secret key and the string to sign is | |||
|
|
|||
| so that the full request query reads | |||
|
|
|||
| > GET - https://playgroundapi.ost.com/transaction-types/edit?api_key=API_KEY&client_transaction_id=CLIENT_TRANSACTION_ID&commission_percent=COMMISSION_PERCENT¤cy_type=CURRENCY_TYPE¤cy_value=CURRENCY_VALUE&kind=KIND&name=NAME&request_timestamp=REQUEST_TIMESTAMP&signature=SIGNATURE | |||
| > GET - `https://playgroundapi.ost.com/transaction-types/edit?api_key=API_KEY&client_transaction_id=CLIENT_TRANSACTION_ID&commission_percent=COMMISSION_PERCENT¤cy_type=CURRENCY_TYPE¤cy_value=CURRENCY_VALUE&kind=KIND&name=NAME&request_timestamp=REQUEST_TIMESTAMP&signature=SIGNATURE` | |||
There was a problem hiding this comment.
I'm confident /transaction-types/edit is / should be a POST
This was referenced May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues 1 - 14 with dev.ost.com
https://github.com/OpenSTFoundation/website-docupony/issues/43