Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve extensionless URL /some-url from file /some-url.html #54

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

chimbori
Copy link
Contributor

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Jekyll.

Fixes #53 and brings this behavior to parity with Jekyll.

The function I modified does not currently have tests, so I created this PR with just the changes to code, didn’t add tests in the same PR.

@chimbori
Copy link
Contributor Author

chimbori commented Nov 6, 2023

Hi @danog, do you need anything else from me to be able to review this PR? Thanks!

@danog
Copy link
Collaborator

danog commented Nov 6, 2023

LGTM, thanks!

@danog danog merged commit cf7a6db into osteele:main Nov 6, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensionless serving is not supported: /page returns 404 when /page.html returns 200
2 participants