Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow range expression as general expressions (not only loops) #65

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

aisbergg
Copy link
Contributor

Currently the range expression (start..end) is only supported in loops. This PR makes is possible to use it as a general expression e.g.:

{% assign l = (1..5) | reverse %}
{% for i in l %}
{{ i -}}
{% endfor %}

results in:

5
4
3
2
1

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

@danog
Copy link
Collaborator

danog commented Aug 23, 2023

Hi, could you rebase this?

@aisbergg
Copy link
Contributor Author

Done. Only took a month to do so 😅

@danog
Copy link
Collaborator

danog commented Sep 24, 2023

Thank you!

@danog danog merged commit 5dfb339 into osteele:main Sep 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants