Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace control #88

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix whitespace control #88

wants to merge 1 commit into from

Conversation

jamslinger
Copy link
Contributor

@jamslinger jamslinger commented May 1, 2024 •
edited
Loading

Checklist

  • I have read the contribution guidelines.
  • make test passes.
  • make lint passes.
  • New and changed code is covered by tests.
  • Performance improvements include benchmarks.
  • Changes match the documented (not just the implemented) behavior of Shopify.

Instead of keeping trimming flags on all tokens, introduce explicit trim tokens: TrimLeftTokenType and TrimRightTokenType, trimWriter configuration is then triggere via (n *TrimNode) render.

@jamslinger
Copy link
Contributor Author

fixes: #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jamslinger