Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushkit (VoIP) Support #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

gus-bn
Copy link

@gus-bn gus-bn commented Oct 6, 2020

  • In order to send pushkit notifications, apns-push-type must be sent as voip
  • Since this value is determined based on content_available for bg of alert values, the cleanest solution would be to allow overriding the request headers. This solution would also support: complication and fileprovider notifications.

Usage:

notification = Apnotic::Notification.new(push_token)
notification.custom_headers = {
  'apns-push-type' => 'voip',
  'apns-expiration' => 0
}
...

Sources:

@drale2k
Copy link

drale2k commented Nov 20, 2020

bump, needed very much

@scottharvey
Copy link

I also needed to send VoIP push notifications so I'm using the branch that @gustavobnmx created, it would be nice to have this merged into the main project. 👍

@benubois
Copy link
Collaborator

benubois commented Sep 7, 2021

Hi @gustavobnmx,

Thanks for making this! I like the symmetry with custom_payload. Having a way to merge in headers provides a valuable escape hatch to add anything without updates to apnotic.

Could the documentation be edited down to just demonstrate what is new around adding custom_headers? The new section feels redundant and the readme is already quite long.

After that would it be possible for you to squash your commits and force-push?

Finally, for voip specifically, what I'd like to see is a proper wrapper around the apns-push-type key, with an eye toward maintaining backward compatibility with background_notification?. However this does not need to hold up the merge of this pull request.

@bhishakBitcanny
Copy link

Is this going to be merged anytime soon? Would really help to solve sending VoIP push.

@ostinelli
Copy link
Owner

@bhishakBitcanny see @benubois previous remark, some work is pending for this to get merged. We welcome some help to close this if you're up for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants