':authority' pseudo-header field support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. Can you please squash into a single reviewable commit, such a minor change should not require more. Thank you. |
According to [RFC7540 8.1.2.3](https://tools.ietf.org/html/rfc7540#section-8.1.2), the client SHOULD use ':authority' request pseudo-header field instead of 'host' request header field. The format of authority is defined in [RFC3986, Section 3.2](https://tools.ietf.org/html/rfc3986#section-3.2). 'userinfo' is deprecated, and SHOULD NOT be included in the request headers.
|
Thanks for your reply. I squashed several commit into a single commit. |
|
Thank you, will merge soon. |
|
This is now merged in and released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC7540 8.1.2.3, the client SHOULD use ':authority' request pseudo-header field instead of 'host' request header field.
There are some websites which does not respond to the request that contains 'host' header field.
If the request contains 'host', Google will close the connection immediately and the response by Twitter will be 404.