print-summary: New script to dump a summary file #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example output: |
|
Works for me. Very useful! Thanks! |
dbnicholson
approved these changes
Mar 2, 2017
print-summary
Outdated
| action='store') | ||
| args = parser.parse_args() | ||
|
|
||
| bytedata = GLib.Bytes.new(open(args.path).read()) |
There was a problem hiding this comment.
A more python-y way to do this would be with a context manager:
with open(args.path) as f:
bytedata = GLib.Bytes.new(f.read())
Then the file is closed immediately whether there's an error or not.
print-summary
Outdated
| d = GLib.Variant.new_from_bytes(typestr, bytedata, False) | ||
|
|
||
| refs = d[0] | ||
| other = d[1] |
There was a problem hiding this comment.
A more python-y way to write this is like:
refs, other = GLib.Variant.new_from_bytes(typestr, bytedata, False)
print-summary
Outdated
| refs = d[0] | ||
| other = d[1] | ||
|
|
||
| for (refname, refdata) in refs: |
print-summary
Outdated
| continue | ||
| csum = '' | ||
| for v in csumarray: | ||
| csum += '%x' % v |
There was a problem hiding this comment.
csum = ''.join(['%x' % v for v in csumarray]) for a one liner.
print-summary
Outdated
| print("{} → {} (size={})".format(refname, csum, size)) | ||
|
|
||
| deltas = other.get('ostree.static-deltas') | ||
| if deltas is not None: |
There was a problem hiding this comment.
If you pass an empty dict as the default to get, then you don't need to check for None and can just loop way:
deltas = others.get('ostree.static-deltas', {})
cgwalters
force-pushed
the
add-print-summary
branch
from
2315fe6
to
2dc1690
Compare
|
Thanks @dbnicholson ! I've merged in all your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for debugging:
https://mail.gnome.org/archives/ostree-list/2017-March/msg00000.html