Add new integration testing flow #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
ci-in-container
branch
3 times, most recently
from
1d5d790
to
c9b81b2
Compare
cgwalters
commented
Dec 16, 2021
lib/src/integrationtest.rs
Outdated
|
|
||
| fn is_container() -> bool { | ||
| // https://stackoverflow.com/questions/20010199/how-to-determine-if-a-process-runs-inside-lxc-docker | ||
| for p in ["/run/.containerenv", "/.dockerenv"] { |
There was a problem hiding this comment.
OK this was fun. I wish I could add a comment on https://stackoverflow.com/questions/20010199/how-to-determine-if-a-process-runs-inside-lxc-docker but apparently I don't have enough reputation.
|
The thing where GH actions gives you a full VM but makes it trivial to run in a (potentially privileged) container there, or jump between containers is actually fairly powerful. This is proving out "integration tests" that jump from a build environment into another container. The main thought here is that with this we can start on #159 and because we'll now need to be testing ostree-rs-ext inside a container. That said, we clearly also want VM tests. |
The core idea here is that we take our built binary and inject it into a fcos container image, where we can do further testing. For now just to prove this out I've added an internal testutils command. (I think I'd like to write more tests in Rust, but to do that correctly we also want a `bin-unit-tests` feature like rpm-ostree has, which can come later)
cgwalters
force-pushed
the
ci-in-container
branch
from
c9b81b2
to
0c297fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core idea here is that we take our built binary and inject
it into a fcos container image, where we can do further testing.
For now just to prove this out I've added an internal testutils
command.
(I think I'd like to write more tests in Rust, but to do that
correctly we also want a
bin-unit-testsfeature like rpm-ostreehas, which can come later)