3 minor patches #274
Merged
3 minor patches #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
approved these changes
Mar 30, 2022
| @@ -342,7 +342,7 @@ impl Chunking { | |||
| ); | |||
| Cow::Owned(r) | |||
| } | |||
| n => Cow::Owned(format!("{} components", n)), | |||
| n => Cow::Owned(format!("{n} components")), | |||
There was a problem hiding this comment.
Oh sweet, will have to remember to start using this more now!
|
Need to bump MSRV here. |
To use the new inline format bits.
Specifically for `commit`.
Minor drive by code improvement.
xref https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings Another drive by code improvement, no immediate motivation. I've just been using it in other places and I think we're fine to hard depend on Rust 1.58 - it's in RHEL8.6 for example.
|
Updated 🆕 MSRV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: Add more docstrings
Specifically for
commit.cli: Use
bool::thenMinor drive by code improvement.
tree-wide: Use some captured identifiers in format strings
xref https://blog.rust-lang.org/2022/01/13/Rust-1.58.0.html#captured-identifiers-in-format-strings
Another drive by code improvement, no immediate motivation. I've
just been using it in other places and I think we're fine to hard depend
on Rust 1.58 - it's in RHEL8.6 for example.