Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused format-version API #475

Merged
merged 1 commit into from
May 10, 2023

Conversation

cgwalters
Copy link
Member

Since we're breaking semver we can just drop this.

Since we're breaking semver we can just drop this.
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 28b7ab0 into ostreedev:main May 10, 2023
@jmarrero
Copy link
Member

@cgwalters and I discussed the trade offs between merging as is as or completely removing the ExportOptions code. I was wondering why we need to add the #[allow(dead_code)] annotation. Colin explained that now that we are just using format 1, nothing is using self.options.format_version. This raises the idea of completely removing the code instead of annotating it. While completely removing it would be cleaner, we decided to keep it as is for now and will reconsider further down the line if there is no near future need to extend this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants