tar: Fix multiple hardlinks #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit handled the case of *one* hardlink, but the logic for the secondary one was backwards. I noticed this when generating a derived image, in some cases we only end up with `/usr/lib/sysimage/rpm-ostree-base-db` as modified, which causes really confusing semantics that look like packages going missing.
cgwalters
force-pushed
the
fix-tar-import
branch
from
16775cc
to
db23ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous commit here (43e1648) handled the case of one hardlink, but the logic for the secondary one was backwards.
I noticed this when generating a derived image, in some cases we only end up with
/usr/lib/sysimage/rpm-ostree-base-dbas modified, which causes really confusing semantics that look like packages going missing.