Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container: Allow alternative formatting to drop ostree-unverified-registry #604

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

cgwalters
Copy link
Member

Since
34fea14 we are backing off the signature verification bits. Let's make it easier to not put those bits in the user's face by adding an alternative formatting that drops it if it's the default.

…gistry`

Since
ostreedev@34fea14
we are backing off the signature verification bits.  Let's make
it easier to not put those bits in the user's face by
adding an alternative formatting that drops it if it's the default.
cgwalters added a commit to cgwalters/bootc that referenced this pull request Feb 13, 2024
Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff *much* less in the user's face
in the default path.
cgwalters added a commit to cgwalters/bootc that referenced this pull request Feb 13, 2024
Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff *much* less in the user's face
in the default path.

Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters added a commit to cgwalters/bootc that referenced this pull request Feb 13, 2024
Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff *much* less in the user's face
in the default path.

Signed-off-by: Colin Walters <walters@verbum.org>
Copy link
Member

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmarrero jmarrero merged commit 4549445 into ostreedev:main Feb 17, 2024
10 checks passed
cgwalters added a commit to cgwalters/bootc that referenced this pull request Mar 18, 2024
Followup to e3db010
where this one was missed.  Copy-pasting that git log
for ease of consumption:

Same motivation as ostreedev/ostree-rs-ext#604

Because fetching from a registry with the default sigverify is
the 90% case default, when we see this (and are formatting for
human consumption), use the "alternate" formatting to just
display the image name.

This makes the ostree stuff *much* less in the user's face
in the default path.

Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants