Depend on oci-spec #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, oci-spec-rs is depending on https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1540-2021-07-29 from Rust 1.54. Hmm. |
cgwalters
force-pushed
the
oci-spec
branch
2 times, most recently
from
76b0112
to
d12d8a4
Compare
|
OK rebased 🏄 and also updated to the new crate version (where the builder pattern is required). This still only touches the writing paths mostly. So there's more we can do to dedup code...we can get rid of our custom |
Since https://github.com/containers/oci-spec-rs now exists, let's use it!
jlebon
approved these changes
Oct 26, 2021
lib/src/container/oci.rs
Outdated
| .build() | ||
| .unwrap(); | ||
| let history = oci_image::HistoryBuilder::default() | ||
| .created_by(concat!("created by ", env!("CARGO_PKG_VERSION"))) |
There was a problem hiding this comment.
Not new, though did you mean
Suggested change
| .created_by(concat!("created by ", env!("CARGO_PKG_VERSION"))) | |
| .created_by(concat!("created by ", env!("CARGO_PKG_NAME"), " v", env!("CARGO_PKG_VERSION"))) |
here?
Spotted in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since https://github.com/containers/oci-spec-rs now
exists, let's use it!