Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OstreeRepo: commit-update-summary should be respected by libostree #1689

Closed
jlebon opened this issue Jul 24, 2018 · 0 comments
Closed

OstreeRepo: commit-update-summary should be respected by libostree #1689

jlebon opened this issue Jul 24, 2018 · 0 comments
Labels
bug good-first-issue good issue for someone new

Comments

@jlebon
Copy link
Member

jlebon commented Jul 24, 2018

Right now, commit-update-summary is handled on the CLI by ostree commit. This means that libostree users won't observe the wanted behaviour.

See #1681.
@jlebon jlebon added bug good-first-issue good issue for someone new labels Jul 24, 2018
@jlebon jlebon mentioned this issue Jul 24, 2018
Closed
jlebon added a commit to jlebon/ostree that referenced this issue Jul 30, 2018
@jlebon
config: Deprecate commit-update-summary option
bbb0861 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689
jlebon added a commit to jlebon/ostree that referenced this issue Jul 30, 2018
@jlebon
lib/config: Deprecate commit-update-summary option
da3c4b9 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689
jlebon added a commit to jlebon/ostree that referenced this issue Jul 30, 2018
@jlebon
lib/config: Deprecate commit-update-summary option
ae5dcd8 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689
jlebon added a commit to jlebon/ostree that referenced this issue Jul 30, 2018
@jlebon
lib/config: Deprecate commit-update-summary option
4fdbaf5 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689
rh-atomic-bot pushed a commit that referenced this issue Aug 1, 2018
@jlebon @rh-atomic-bot
lib/config: Deprecate commit-update-summary option
3f159c5 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: #1689

Closes: #1693
Approved by: mwleeds
jlebon added a commit to jlebon/ostree that referenced this issue Aug 1, 2018
@jlebon
lib/config: Deprecate commit-update-summary option
0d07b3f 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689
mwleeds pushed a commit to mwleeds/ostree that referenced this issue Sep 24, 2018
@jlebon @mwleeds
lib/config: Deprecate commit-update-summary option
917ca18 
Now that we have `auto-update-summary`, there is no point in having
`commit-update-summary`. The latter also only had an effect through
the `commit` CLI command, whereas the former is embedded directly in
libostree.

There is one corner case that slips through: `commit` would update the
summary file even if orphan commits were created, which we no longer do
here. I can't imagine anyone relying on this, so it seems safe to drop.

Closes: ostreedev#1689

Closes: ostreedev#1693
Approved by: mwleeds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good-first-issue good issue for someone new
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlebon