Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Transfer-Encoding: gzip when downloading summaries #802

Closed
alexlarsson opened this issue Apr 20, 2017 · 0 comments
Closed

Support Transfer-Encoding: gzip when downloading summaries #802

alexlarsson opened this issue Apr 20, 2017 · 0 comments
Labels
enhancement

Comments

@alexlarsson
Copy link
Member

The summary can be pretty large, and it is not by itself compressed. We should indicate in the headers when getting this that we accept e.g. Transfer-Encoding: gzip, as that would help with the download size.

This isn't true for the rest of the files though, as they are generally already compressed.
alexlarsson added a commit to alexlarsson/ostree that referenced this issue May 24, 2017
@alexlarsson
fetcher: Send Accept-Encoding: gzip when downloading summary
52ba5cb 
The summary file can get large, but it compresses well (something
which is not true of other files in the ostree repo which are
already compressed). By sending Accept-Encoding: gzip (and
handling the compressed results) we send a lot less data.

I set up the flathub repo (http://flathub.org/repo) to enable
gzip for the summary file (only), and the result is that the
331514 byte large summary was transferred in 122889 bytes.
On my (fast) network this decreased the time i took to do
"flatpak remote-ls flathub" by about 100msec.

This fixes ostreedev#802
@alexlarsson alexlarsson mentioned this issue May 24, 2017
Closed
ramcq pushed a commit to endlessm/ostree that referenced this issue May 24, 2017
@alexlarsson @ramcq
fetcher: Send Accept-Encoding: gzip when downloading summary
3558e13 
The summary file can get large, but it compresses well (something
which is not true of other files in the ostree repo which are
already compressed). By sending Accept-Encoding: gzip (and
handling the compressed results) we send a lot less data.

I set up the flathub repo (http://flathub.org/repo) to enable
gzip for the summary file (only), and the result is that the
331514 byte large summary was transferred in 122889 bytes.
On my (fast) network this decreased the time i took to do
"flatpak remote-ls flathub" by about 100msec.

This fixes ostreedev/ostree#802

Closes: #882
Approved by: cgwalters

(cherry picked from commit be0c02d)
Signed-off-by: Robert McQueen <rob@endlessm.com>

Conflicts:
  src/libostree/ostree-fetcher-curl.c (deleted, no curl in this version)
  src/libostree/ostree-repo-pull.c (trivial merge)
@dbnicholson dbnicholson mentioned this issue Jan 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fetcher: Send Accept-Encoding: gzip when downloading summary alexlarsson/ostree
2 participants
@cgwalters @alexlarsson