lib/fetcher: Allow clients to append to User-Agent #1496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving WIP for feedback before adding tests. |
|
Looks good to me. |
|
Looks sane to me too. |
We do already have `http-headers`, which potentially could be used to allow clients to completely override the field, but it seems like the more common use case is simply to append.
jlebon
force-pushed
the
pr/custom-user-agent
branch
from
8a1e2f1
to
1f53d27
Compare
jlebon
changed the title
|
Dropped WIP and added tests! ⬆️ |
|
☀️ Test successful - status-atomicjenkins |
alexlarsson
added a commit
to alexlarsson/flatpak
that referenced
this pull request
Mar 28, 2018
This uses the new ostree feature at: ostreedev/ostree#1496 Note, this will only work with the current ostree master, and does nothing on older versions.
rh-atomic-bot
pushed a commit
to flatpak/flatpak
that referenced
this pull request
Mar 28, 2018
This uses the new ostree feature at: ostreedev/ostree#1496 Note, this will only work with the current ostree master, and does nothing on older versions. Closes: #1533 Approved by: mwleeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do already have
http-headers, which potentially could be used toallow clients to completely override the field, but it seems like the
more common use case is simply to append.