tests/installed: Make reboot task less racy #1548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 19, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: jlebon
|
💔 Test failed - status-atomicjenkins |
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries.
cgwalters
force-pushed
the
reboot-ansible
branch
from
12dac6a
to
9414bea
Compare
|
Ahh OK, that's an instance of #1549. |
|
🙀 |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
|
Whoops! I have this filter that marks all @rh-atomic-bot notifications as read unless it's "Test timed out" or "Test failed". I tweaked it to also leave the "try again" emails unread. |
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
|
💔 Test failed - status-atomicjenkins |
|
@rh-atomic-bot retry
:cry:
|
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
Let's only print if the commit isn't already partial; this addresses a spam of "marking commit partial" from fsck. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
No need to poll every second, there's going to be some latency here and we want to avoid the overhead of polling. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 20, 2018
Hopefully we'll fix this soon. Closes: #1548 Approved by: cgwalters
|
@rh-atomic-bot, stop being such a jerk! |
|
💔 Test failed - status-atomicjenkins |
|
OK, I thought I had it, it seemed fairly robust locally but apparently no dice. I briefly looked at doing a custom Ansible module, but (again just from initial investigation) it seems we'd really need the engine to understand this; we basically want an atomic combination of |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
This took a whole lot of experimentation. I hit upon the idea of doing a `systemctl stop sshd` to avoid the situation where we might ssh back into the system while it's in the process of shutting down. Ultimately the other fix is disabling `ControlMaster`; see for example: ansible/ansible#17935 Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
Let's only print if the commit isn't already partial; this addresses a spam of "marking commit partial" from fsck. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
No need to poll every second, there's going to be some latency here and we want to avoid the overhead of polling. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
Hopefully we'll fix this soon. Closes: #1548 Approved by: cgwalters
|
Going back to longer timeouts seems to be OK in some manual testing in the CI env. We'll just live with races temporarily...I'll investigate other approaches. |
|
💔 Test failed - status-atomicjenkins |
|
Well, the PR test definitely passed, so 🍾 🎊. |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
It seems like 240 retries is just not long enough for all the non-destructive tests running in parallel to finish. Let's crank that up to 500 retries. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
Let's only print if the commit isn't already partial; this addresses a spam of "marking commit partial" from fsck. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
No need to poll every second, there's going to be some latency here and we want to avoid the overhead of polling. Closes: #1548 Approved by: cgwalters
rh-atomic-bot
pushed a commit
that referenced
this pull request
Apr 23, 2018
Hopefully we'll fix this soon. Closes: #1548 Approved by: cgwalters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took a whole lot of experimentation. I hit upon the idea
of doing a
systemctl stop sshdto avoid the situation where wemight ssh back into the system while it's in the process of shutting
down.
Ultimately the other fix is disabling
ControlMaster; seefor example: ansible/ansible#17935