Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libglnx to get g_autoptr backports #1603

Closed
wants to merge 1 commit into from
Closed

Update libglnx to get g_autoptr backports #1603

wants to merge 1 commit into from

Conversation

mwleeds
Copy link
Member

@mwleeds mwleeds commented May 29, 2018

No description provided.

@papr-bot
Copy link

Can one of the admins verify this patch?

@jlebon
Copy link
Member

jlebon commented May 29, 2018

error: Commit message for 1859819 changes a submodule, but does not match regex Update submodule: libglnx

Ahh yes. You'll want to add: "Update submodule: libglnx" to the commit message to convince the bot you really meant to update a submodule. :) We've had issues in the past where PRs accidentally altered submodules.

@jlebon
Copy link
Member

jlebon commented May 29, 2018

@rh-atomic-bot r+ af72e87

rh-atomic-bot pushed a commit that referenced this pull request May 29, 2018
@mwleeds @rh-atomic-bot
Update libglnx to get g_autoptr backports
87d1a1c 
Update submodule: libglnx

Closes: #1603
Approved by: jlebon
@rh-atomic-bot
Copy link

⌛ Testing commit af72e87 with merge 87d1a1c...

@cgwalters
Copy link
Member

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit af72e87 with merge e774d59...

rh-atomic-bot pushed a commit that referenced this pull request May 29, 2018
@mwleeds @rh-atomic-bot
Update libglnx to get g_autoptr backports
e774d59 
Update submodule: libglnx

Closes: #1603
Approved by: jlebon
@jlebon
Copy link
Member

jlebon commented May 29, 2018

@rh-atomic-bot retry

@rh-atomic-bot
Copy link

⌛ Testing commit af72e87 with merge ee0d9bb...

@rh-atomic-bot
Copy link

☀️ Test successful - status-atomicjenkins
Approved by: jlebon
Pushing ee0d9bb to master...

@ebassi
Copy link
Contributor

ebassi commented May 29, 2018

After this landed, GNOME Continuous breaks during check out:

Cloning into 'libglnx'...
fatal: reference is not a tree: e1a78cf2f5351d5394ccfb79f3f5a7b4917f73f3
Unable to checkout 'e1a78cf2f5351d5394ccfb79f3f5a7b4917f73f3' in submodule path 'libglnx'

@cgwalters
Copy link
Member

Probably a race between the resolve/build steps, should (hopefully) fix itself next cycle. Ping if not.

@ebassi
Copy link
Contributor

ebassi commented May 30, 2018

A point made by @alexlarsson: the Git submodule for libglnx still points to git.gnome.org, and some versions of Git do not really like redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mwleeds @papr-bot @jlebon @rh-atomic-bot @cgwalters @ebassi