src/ostree: Fix split string containing multiple dots '.'

[sinnykumari]

This commit fixes fetching of remote repo name containing
multiple dots in config file using ostree config set|get
option.

It also adds test for ostree config get|set

Fixes #1565

[jlebon]

Hmm, how about instead of this, we use strrchr instead strchr below so that we find the last period in the string? That way, we have a single path for either kind of section names.

[sinnykumari]

Umm, so config file can have something like below:

[remote "org.mozilla.FirefoxRepo"]
gpg-verify=true
gpg-verify-summary=true
url=https://firefox-flatpak.mojefedora.cz/repo/
xa.title=Unofficial Firefox Flatpak Repository
xa.title-is-set=true

In some cases using strrchr won't work appropriately. For example, we want to fetch value of xa.title, in this case split_key_string() will have value of k as something like remote "org.mozilla.FirefoxRepo".xa.title . Using strrchr will give as match for title instead of xa.title .

[jlebon]

So looking at https://gitlab.gnome.org/GNOME/glib/blob/83a4cab12c2d00dbfe6013d071cff2da310109a4/glib/gkeyfile.c#L4119, it seems like group names can have almost any characters, except square brackets. If that's the case, then it seems like even ". is not strong enough?

Here's a strawman: we support an alternative [grouname].keyname syntax. This will allow us to completely disambiguate them. E.g. one would write ostree config get '[remote "foo.bar.baz"]'.xa.title. What do you think?

(Note for remotes specifically, there's an open PR (#1166) that will make it more natural to change remote configs from the cmdline.)

[sinnykumari]

Yes! looking for [grouname].keyname sounds good to me, will update PR with changes. Does this change require updating ostree documentation anywhere?

[jlebon]

I think just the man page for the command (it's in man/ostree-config.xml).

[cgwalters]

Here's a strawman: we support an alternative [grouname].keyname syntax.

Seems sane to me, though maybe also:

ostree config get --group 'remote "foo.bar.baz"' 'xa.title'

[sinnykumari]

I like the --group idea, will update the PR with changes.

[dustymabe]

thanks for the update sinny.. is this ready for review?

[sinnykumari]

Ah yes, this is ready for review. Latest changes implement --group option in ostree config to pass Group Name followed by Key .

[cgwalters]

Shouldn't this be argc < 3? Oh wait, I see. OK, I think we want the --group flag to take an argument. Rather than G_OPTION_ARG_NONE, use G_OPTION_ARG_STRING. Then the opt_group will itself contain the group variable. Does that make sense?

Doing this should simplify a lot of the processing, particularly if we combine the argc validation with parsing, something like:

if (opt_group)
  {
    if (argc < 3)
      {
        g_set_error (...)
        goto out;
      }

    section = g_strdup (opt_group);
    key = g_strdup (argv[2]);
    value = g_strdup (argv[3]);
  }
else
  {
    if (argc < 3)
      {
        g_set_error (...)
        goto out;
      }

    section_key = argv[2];
    value = argv[3];
    if (!split_key_string (section_key, &section, &key, error))
      goto out;
  }

[sinnykumari]

Thanks Colin for reviewing it!
I agree that using G_OPTION_ARG_STRING makes things simpler. I have updated PR with required changes.

[cgwalters]

Thanks!

@rh-atomic-bot r+ d6eeb61

[rh-atomic-bot]

⌛ Testing commit d6eeb61 with merge dde3f1c...

[rh-atomic-bot]

☀️ Test successful - status-atomicjenkins
Approved by: cgwalters
Pushing dde3f1c to master...

[dustymabe]

❤️ - nice work @sinnykumari - thanks @cgwalters for reviewing

[sinnykumari]

Thanks @dustymabe @jlebon and @cgwalters for the help!