sysroot: Add a clearer error if /boot/loader isn't found #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've seen people confused by this error in the case where `/boot` isn't mounted or the BLS fragments were deleted, etc. If you understand ostree deeply it's clear but, let's do better here and a direct error message for the case where we can't find `/boot/loader` which is the majority of these. The other case could happen if e.g. just the BLS fragment for the booted deployment was deleted; let's reword that one a bit too.
|
LGTM! |
|
⚡ Test exempted: pull fully rebased and already tested. |
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Oct 25, 2019
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
d4s
pushed a commit
to d4s/ostree
that referenced
this pull request
Nov 4, 2019
I've seen people confused by this error in the case where `/boot` isn't mounted or the BLS fragments were deleted, etc. If you understand ostree deeply it's clear but, let's do better here and a direct error message for the case where we can't find `/boot/loader` which is the majority of these. The other case could happen if e.g. just the BLS fragment for the booted deployment was deleted; let's reword that one a bit too. Closes: ostreedev#1905 Approved by: rfairley
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Nov 11, 2019
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Nov 22, 2019
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Dec 20, 2019
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Jan 27, 2020
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Feb 4, 2020
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Feb 5, 2020
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Feb 20, 2020
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Apr 21, 2021
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
May 20, 2021
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
r4f4
added a commit
to r4f4/ostree
that referenced
this pull request
Aug 2, 2021
Fixes ostreedev#1905 Signed-off-by: Rafael Fonseca <r4f4rfs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen people confused by this error in the case where
/bootisn't mounted or the BLS fragments were deleted, etc.If you understand ostree deeply it's clear but, let's do
better here and a direct error message for the case where
we can't find
/boot/loaderwhich is the majority of these.The other case could happen if e.g. just the BLS fragment
for the booted deployment was deleted; let's reword that
one a bit too.