Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grub2: Exit gracefully if the configuration has BLS enabled #1929

Commits on Sep 26, 2019

  1. grub2: Exit gracefully if the configuration has BLS enabled

    Since Fedora 30 grub2 has support to populate its menu entries from the
    BootLoaderSpec fragments in /boot/loader/entries, so there's no need to
    generate menu entries anymore using the /etc/grub.d/15_ostree script.
    
    But since ostree doesn't update the bootloader, it may be that the grub2
    installed is an old one that doesn't have BLS support.
    
    For new installs, GRUB_ENABLE_BLSCFG=true is set in /etc/default/grub to
    tell the /etc/grub.d/10_linux script if a blscfg command has to be added
    to the generated grub2 config file.
    
    So check if BLS is enabled in /etc/default/grub and only add the entries
    if that's not the case. Otherwise the menu entries will be duplicated.
    
    The approach has the drawback that if a user sets GRUB_ENABLE_BLSCFG=true
    in /etc/default/grub without updating grub2, they will get an empty menu.
    Since there won't be any entries created by the 30_ostree script and the
    blscfg command won't work on the older grub2.
    
    Unfortunately there is no way to know if the installed grub2 already has
    BLS support or not.
    
    Related: https://bugzilla.redhat.com/show_bug.cgi?id=1751272#c27
    martinezjavier committed Sep 26, 2019
    Copy the full SHA
    94f60af View commit details
    Browse the repository at this point in the history