[merged] Add URL override for fetching objects #271
Conversation
The "override-url" option allows to use the other URL while still using some options from the passed remote.
This allows ostree to pull the objects from a different URL without modifying the repo's config.
|
Can one of the admins verify this patch?
|
|
Can you add a test case? Examples are in |
|
One test case would be to have a repo that has an upstream remote, clone the remote into a different path, then rm -rf the original, then do a pull with |
|
Sure, will get to it tomorrow. |
Might be useful to see what files the client wants to fetch.
|
Updated. I added a |
| { | ||
| GOutputStream *stream = NULL; | ||
|
|
||
| if (g_strcmp0(opt_log, "-") == 0) |
There was a problem hiding this comment.
Missing space between identifier and paren here.
|
Test LGTM. |
|
Updated. Added the check for |
|
In the future, I generally prefer test cases to come in the same commit as the code introducing them. Not a big deal though. |
|
Alright, will remember next time. |
This allows ostree to pull the objects from a different URL without modifying the repo's config. Closes: #271 Approved by: cgwalters
Might be useful to see what files the client wants to fetch. Closes: #271 Approved by: cgwalters
Closes: #271 Approved by: cgwalters
|
☀️ Test successful - status-atomicjenkins |
cgwalters-bot
changed the title
Split off from ostreedev#270 This changes all the places where we muck with paths to use `os.path.join()`. Hopefully this is start of some coding standards as discussed in ostreedev#271.
This adds an
override-urloption toostree_repo_pull_with_options, which, if specified, overrides the URL taken from repo config for a given remote.This also adds a
--urloption toostree pullwhich uses the above option.