Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value of generator on non-ostree systems #2911

Merged
merged 1 commit into from Jun 29, 2023

Conversation

cgwalters
Copy link
Member

Commit aa72caf
regressed the ostree-system-generator on non-ostree systems. If there's no ostree= karg, we need to just exit 0.

Closes: #2909
Fixes: aa72caf

Commit aa72caf
regressed the `ostree-system-generator` on non-ostree systems.
If there's no `ostree=` karg, we need to just exit 0.

Closes: ostreedev#2909
Fixes: aa72caf
@ericcurtin
Copy link
Collaborator

LGTM, responding on phone. Had not noticed this regression, apologies.

@dbnicholson
Copy link
Member

I don't know what to make of the kola failure. I can't tell if it's transient or related to this change.

@cgwalters
Copy link
Member Author

I think that's just an instance of a low-frequency flake we've seen; #2912 will help a little in debugging it hopefully.

@cgwalters
Copy link
Member Author

Flaked on coreos/fedora-coreos-tracker#1511
/override continuous-integration/jenkins/pr-merge

@dbnicholson dbnicholson merged commit c2ad2d2 into ostreedev:main Jun 29, 2023
20 of 22 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

Flaked on coreos/fedora-coreos-tracker#1511
/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericcurtin
Copy link
Collaborator

This still fails in the Android Boot case, because this regex basically doesn't apply:

regex = g_regex_new ("^/ostree/boot.[01]/([^/]+)/", 0, 0, NULL);

but I'm gonna fix it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ostree-system-generator failed with exit status 1
3 participants