lib/deploy: Log SELinux policy refresh #3081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a suspicion that the `semodule -N --refresh` we do here is involved in coreos/fedora-coreos-tracker#1597. Let's log when we execute it and include its time. While we're here, also log the time it takes to `syncfs()` and the fsfreeze/thaw cycling. It's logged in a structured journal entry, but that's less accessible than just having it in the journal message field.
jlebon
force-pushed
the
pr/log-selinux-refresh
branch
from
2cb4911
to
bdac515
Compare
cgwalters
approved these changes
Oct 20, 2023
Comment on lines
+1654
to
+1655
| ot_journal_print (LOG_INFO, "Completed syncfs() for system root in %" G_GUINT64_FORMAT " ms", | ||
| end_msec - start_msec); |
There was a problem hiding this comment.
This is completely fine but I previously changed it because in the end the journal keeps timestamps so one can just diff those to see.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a suspicion that the
semodule -N --refreshwe do here is involved in coreos/fedora-coreos-tracker#1597. Let's log when we execute it and include its time.While we're here, also log the time it takes to
syncfs()and the fsfreeze/thaw cycling. It's logged in a structured journal entry, but that's less accessible than just having it in the journal message field.