status: Pass correct remote name when verifying #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default `ostree admin status` tries to do signature verification, but doesn't error out if that fails. However, an extremely longstanding bug here is that we passed the "osname" aka stateroot instead of the remote name. This happens to work for e.g. Fedora Silverblue today, where they are the same. It doesn't work on FCOS (remote = fedora, stateroot = fedora-coreos).
Since it's really expensive in some cases.
ericcurtin
approved these changes
Jan 5, 2024
|
Tested, also superfast: |
|
Sorry this failed one of the builds because of ifdef differences, gonna fix. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
ostree admin statustries to do signature verification, but doesn't error out if that fails.However, an extremely longstanding bug here is that we passed the "osname" aka stateroot instead of the remote name. This happens to work for e.g. Fedora Silverblue today, where they are the same. It doesn't work on FCOS (remote = fedora, stateroot = fedora-coreos).