status: Introduce tool to quickly check if we are booted as default #3134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcurtin
commented
Jan 5, 2024
cgwalters
reviewed
Jan 5, 2024
cgwalters
reviewed
Jan 5, 2024
ericcurtin
force-pushed
the
query-boot-real
branch
3 times, most recently
from
debcd8d
to
6b50dfb
Compare
cgwalters
requested changes
Jan 5, 2024
Generally in ostree based systems you would expect to boot into deployment 0, in rollback conditions triggered by greenboot-related rollbacks this might not be the case. This is a tool to detect this. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ericcurtin
force-pushed
the
query-boot-real
branch
from
6b50dfb
to
1f1a405
Compare
Document the various CLI options. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
It was a copy-paste of another description, rather than it's own. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ericcurtin
force-pushed
the
query-boot-real
branch
from
1f1a405
to
46bae54
Compare
|
This one is ready for re-review @cgwalters I believe everything is addressed |
cgwalters
approved these changes
Jan 8, 2024
jlebon
reviewed
Jan 9, 2024
| </varlistentry> | ||
|
|
||
| <varlistentry> | ||
| <term><option>--version</option>--version</term> |
| NULL }, | ||
| { "skip-signatures", 'S', 0, G_OPTION_ARG_NONE, &opt_skip_signatures, "Skip signatures in output", | ||
| NULL }, | ||
| { "query-booted", 'Q', 0, G_OPTION_ARG_NONE, &opt_query_booted, |
There was a problem hiding this comment.
This is pure bikeshed, but I think this would be better named e.g. --is-default. Somewhat precedence are the systemctl is-* commands that also print strings. --query-booted is a bit ambiguous.
| "Output the string \"default\" if the default deployment is the booted one, \"not-default\" if " | ||
| "we are booted in a non-default deployment (e.g. the user interactively chose a different " | ||
| "entry in the bootloader menu, or the bootloader rolled back automatically, etc.). If we are " | ||
| "not in a booted OSTree system, an error is returned.", |
There was a problem hiding this comment.
Minor: this is duplicating the manpage. These docstrings are usually more brief. Maybe e.g.
Output "default" if booted into the default deployment, otherwise "not-default"
?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally in ostree based systems you would expect to boot into deployment 0, in rollback conditions triggered by greenboot-related rollbacks this might not be the case. This is a tool to detect this.