Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2023.8-3 coverity minor fixes #3263

Closed
wants to merge 10 commits into from
Closed

2023.8-3 coverity minor fixes #3263

wants to merge 10 commits into from

Commits on Jun 12, 2024

  1. checksum: Null terminate buffer 

    Coverity points out that `buffer` is an unterminated string.
g_checksum_update() expects a null-terminated string.
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    a8c3c3d View commit details
    Browse the repository at this point in the history

  2. tree: autofree name var 

    Coverity points out that we have a memory leak from `g_strdup(name)`
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    20a333c View commit details
    Browse the repository at this point in the history

  3. commit: Null terminate target_buf var 

    Coverity points out that we are passing an unterminated string to
sprintf().
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f120b7b View commit details
    Browse the repository at this point in the history

  4. repo: Return copy of local var ret 

    Coverity points out that we are returning `stbuf` which is a local
variable.
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    d049c1f View commit details
    Browse the repository at this point in the history

  5. repo: Free actual pointer instead of stolen pointer 

    Coverity points out that ostree_repo_finder_result_free() is freeing
an incorrect pointer `(gpointer)g_steal_pointer(&results->pdata[i])`.
Since we are not returning this value, we shouldn't need to transfer
ownership of the pointer. Instead, we should free the actual pointer.
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    22b77f1 View commit details
    Browse the repository at this point in the history

  6. repo: Autofree ret_rollsum 

    Coverity points out that we have a memory leak from `ret_rollsum`.
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    383f908 View commit details
    Browse the repository at this point in the history

  7. repo: Autofree dir_or_file_path 

    Coverity points out that we have a memory leak from
g_strdup(dir_or_file_path).
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    b42ef62 View commit details
    Browse the repository at this point in the history

  8. repo: Autofree contents of input_mfile 

    Coverity points out that we have memory leak from
g_mapped_file_get_contents(input_mfile).
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    81125ff View commit details
    Browse the repository at this point in the history

  9. sysroot: Autofree devpath 

    Coverity points out that we have a memory leak from g_strdup(devpath).
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    377dc62 View commit details
    Browse the repository at this point in the history

  10. prepare: Change mount etc to absolute path 

    Coverity points out that ""/sysroot.tmp/etc"" could be a copy-paste
error.
    @lukewarmtemp
    lukewarmtemp committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    4b0fec2 View commit details
    Browse the repository at this point in the history