2023.8-3 coverity scan #3265
Merged
2023.8-3 coverity scan #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/prepare-root
dbnicholson
previously requested changes
Jun 13, 2024
There was a problem hiding this comment.
This seems more reasonable, but now there are lots of failing tests. For instance, one of the tests fails like this:
++ ostree --repo=ostree-srv/gnomerepo static-delta generate main
modified: 1
new reachable: metadata=3 content regular=2 symlink=0
rollsum for 0/1 modified
processing bsdiff: [0/1]
fallback for c5efd04e28fd1f9ae16cd119bb79766cdf042b3f1ef89a282f0b3ca68c062b8c (21.9 MB)
part 1 n:3 compressed:585 uncompressed:524
uncompressed=524 compressed=585 loose=484
rollsum=0 objects, 0 bytes
bsdiff=1 objects
++ ostree --repo=ostree-srv/gnomerepo summary -u
++ cd /test-tmp/tap-test.KzJhuj
++ ostree --repo=repo pull origin main
/__w/ostree/ostree/ci-build/../tests/pull-test.sh: line 573: 37143 Segmentation fault (core dumped) ${CMD_PREFIX} ostree --repo=repo pull origin main
If I had to guess, this is from the change in ostree_repo_static_delta_execute_offline_with_signature. Possibly g_path_get_dirname has slightly different semantics than dirname.
lukewarmtemp
force-pushed
the
2023.8-3-coverity-scan
branch
2 times, most recently
from
09d4fd5
to
1b2e9af
Compare
ericcurtin
reviewed
Jun 17, 2024
cgwalters
reviewed
Jun 18, 2024
cgwalters
reviewed
Jun 18, 2024
lukewarmtemp
force-pushed
the
2023.8-3-coverity-scan
branch
9 times, most recently
from
42366e6
to
5b79d5a
Compare
cgwalters
requested changes
Jun 19, 2024
Coverity points out that we have a memory leak from `g_strdup(name)`. `insert_child_mtree()` takes a const char * and duplicates it. `name` can be passed directly to `insert_child_mtree()`.
Coverity points out that we are passing an unterminated string to sprintf(). Fix by using snprintf() which stores the content as a C string.
Coverity points out that we have a memory leak from `g_strdup(dir_or_file_path)`. Make the duplication of the string a temporary variable that is freed using `g_autofree`.
Coverity points out that ""/sysroot.tmp/etc"" could be a copy-paste error. This is mistake from coverity, but to supress the warning, we create a global var, tmp_sysroot_etc, which replaces all instances of TMP_SYSROOT "/etc".
lukewarmtemp
force-pushed
the
2023.8-3-coverity-scan
branch
from
5b79d5a
to
e99693c
Compare
cgwalters
approved these changes
Jun 20, 2024
lukewarmtemp
dismissed
dbnicholson’s stale review
Change reverted since it made the code more complex. This change request is no longer applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tree: Fix
namememory leakCoverity points out that we have a memory leak from
g_strdup(name).insert_child_mtree()takes a const char * and duplicates it.namecan be passed directly toinsert_child_mtree().commit: Null terminate
target_bufvarCoverity points out that we are passing an unterminated string to
sprintf().
repo: Fix
dir_or_file_pathmemory leakCoverity points out that we have a memory leak from
g_strdup(dir_or_file_path). We useg_path_get_dirname()whichmodifies the string in place, to which coverity should understand.
prepare: Create global var for tmp_sysroot_etc
Coverity points out that ""/sysroot.tmp/etc"" could be a copy-paste
error. This is mistake from coverity, but to supress the warning,
we create a global var, tmp_sysroot_etc, which replaces all
instances of TMP_SYSROOT "/etc".