Allow passing options through to Ajv #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigpopakap
commented
Feb 10, 2020
bigpopakap
commented
Feb 10, 2020
bigpopakap
commented
Feb 10, 2020
ostrowr
requested changes
Feb 10, 2020
There was a problem hiding this comment.
Thanks!
I'm definitely game to add the ajvOptions parameter.
Do you mind splitting this into 2 PRs – one that adds the ajvOptions parameter, which I'll be happy to take ASAP – and one that changes the type on AdditionalProperties? I want to discuss that change a little more, since I'm not sure I want to explicitly only allow false for that type.
|
Thanks for the quick response! I just split it up (but I left the |
bigpopakap
changed the title
ostrowr
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to be able to pass options through to Ajv (here is the doc about the available options. For my particular use case, I want to set
verbose: true; removeAdditional: true, allErrors: true